Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Cypress devices #601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Cypress devices #601

wants to merge 1 commit into from

Conversation

MarianSavchuk
Copy link
Contributor

No description provided.

@flit flit added the backlog label Mar 8, 2019
@flit
Copy link
Collaborator

flit commented Mar 13, 2019 •
edited
Loading

@p2k000 Can you please rebase onto master? You might want to squash down to 1 or 2 commits. You will need to force push.

The recent changes to add the K26F HIC are showing up in this PR, which greatly increases the number of changed files. This is also why projects.yaml is showing as having conflicts.

Thanks!

Btw, we prefer to not have merges to/from master or other branches in pull requests. This keeps the git history much cleaner.

@flit
Copy link
Collaborator

flit commented Mar 20, 2019

@p2k000 Would you mind rebasing and squashing? We need to remove the merge commits to have a clean commit history. You will need to force push after you rebase. Thanks!

flit
flit reviewed Mar 20, 2019
View reviewed changes
source/board/cy8ckit.c Outdated Show resolved Hide resolved
flit
flit requested changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@flit flit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments for requested changes. Also need to rebase on top of #612 once that is merged. And please squash to a single commit when you rebase.

flit
flit reviewed Mar 22, 2019
View reviewed changes
source/daplink/daplink.h Outdated Show resolved Hide resolved
@flit
Copy link
Collaborator

flit commented Mar 22, 2019

Fyi, #612 has been merged now. You can now rebase on top of master and remove the target-specific changes to common code in this PR.

@MarianSavchuk MarianSavchuk force-pushed the cyDAPLink branch 2 times, most recently from 97d23fc to 309d181 Compare April 12, 2019 14:29
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2019

Fyi, #612 has been merged now. You can now rebase on top of master and remove the target-specific changes to common code in this PR.

Please rebase again. Shall we proceed with this PR? what is the status here after the last review

@MarianSavchuk
Copy link
Contributor Author

@0xc0170, I will be ready to publish all modified sources on WW1940. At the moment, almost all comments are resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2020

@MarianSavchuk I merged one of your PRs, reviewing others. This will need a rebase (and its ready for final review?). let me know

@0xc0170 0xc0170 requested a review from flit March 30, 2020 11:20
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 30, 2020

/morph test

@0xc0170

This comment has been minimized.

Sign in to view
1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2020

/morph test

0xc0170
0xc0170 reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks to be target related, will review later today hopefully.

source/usb/usb_lib.c Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

/morph test

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2020 

11:50:39 [Error] CyBootAsmRv.s@49,22: A1516E: Bad symbol 'CYDEV_INSTRUCT_CACHE_ENABLED', not defined or external
11:50:40 [ERROR] ".\\source\\hic_hal\\cypress\\psoc5lp\\armcc\\CyBootAsmRv.s", line 29: Error: A1023E: File "cyfitterrv.inc" could not be opened: No such file or directory
11:50:40    29 00000000     GET cyfitterrv.inc
11:50:40 ".\\source\\hic_hal\\cypress\\psoc5lp\\armcc\\CyBootAsmRv.s", line 49 (column 8): Error: A1516E: Bad symbol 'CYDEV_INSTRUCT_CACHE_ENABLED', not defined or external
11:50:40    49 00000000     IF CYDEV_INSTRUCT_CACHE_ENABLED == 1
11:50:40                       ^
11:50:40 2 Errors, 0 Warnings

Build errors reported, please review

@raveslave
Copy link

will this happen? @MarianSavchuk please consider adding psoc4 as well

@mathias-arm mathias-arm added the hic label Jun 8, 2021
@MarianSavchuk MarianSavchuk force-pushed the cyDAPLink branch 2 times, most recently from b0a0783 to acd2c9f Compare October 1, 2021 11:17
@MarianSavchuk
Copy link
Contributor Author

@flit, @0xc0170
Could you please consider this PR again.
All your previous comments have been addressed.

@nimish
Copy link

nimish commented Apr 28, 2022

@flit @0xc0170 -- any chance for a re-review?

@mbrossard mbrossard requested review from mbrossard and mathias-arm and removed request for 0xc0170 and flit January 4, 2023 03:15
@mbrossard
Copy link
Contributor

Hi @nimish @MarianSavchuk, I failed to notice this PR was still active. Could you rebase and add the startup for GCC ARM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@flit flit flit requested changes

@brianesquilona brianesquilona brianesquilona left review comments

@mbrossard mbrossard Awaiting requested review from mbrossard

@mathias-arm mathias-arm Awaiting requested review from mathias-arm

Assignees
No one assigned
Labels
backlog hic needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MarianSavchuk @flit @0xc0170 @raveslave @nimish @mbrossard @brianesquilona @mathias-arm