Replace some memcpy calls with struct assignments #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An advantage of struct assignments is that the compiler does type checking. It will also avoid the potential mistake of passing an incorrect third argument to memcpy(). To avoid conflict with a pending pull request, this pull request does not change src/read.c.
|
lgtm. This is part of the motivation of preferring sizeof(var) over sizeof(type) in other constructions. In the end these should become memcpy's. Was there a bug? |
y-guyon
approved these changes
Mar 15, 2022
wantehchang
added a commit
to wantehchang/libavif
that referenced
this pull request
Mar 17, 2022
An advantage of struct assignments is that the compiler does type checking. It will also avoid the potential mistake of passing an incorrect third argument to memcpy(). This pull request finishes the job of AOMediaCodec#878.
wantehchang
added a commit
to wantehchang/libavif
that referenced
this pull request
Mar 17, 2022
An advantage of struct assignments is that the compiler does type checking. It will also avoid the potential mistake of passing an incorrect third argument to memcpy(). This pull request finishes the job of AOMediaCodec#878.
wantehchang
added a commit
that referenced
this pull request
Mar 17, 2022
An advantage of struct assignments is that the compiler does type checking. It will also avoid the potential mistake of passing an incorrect third argument to memcpy(). This pull request finishes the job of #878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An advantage of struct assignments is that the compiler does type
checking. It will also avoid the potential mistake of passing an
incorrect third argument to memcpy().
To avoid conflict with a pending pull request, this pull request does
not change src/read.c.