Fix PackageTarget.from_str for linux systems #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the worker on linux systems (NixOS) makes the worker start with
unknown
target, which breaks the vorpal builds as well.On linux, the
get_default_system
function here returnsARCH: x86_64, OS: linux -> 'x86_64-linux'
, which is then passed to theget_package_system
function here.The
get_package_system
function containslet target = system.to_lowercase().replace("_", "-");
line here, which convertsx86_64-linux
tox86-64-linux
, which doesn't match any of thePackageTarget
s.This PR removes the
let target = system.to_lowercase().replace("_", "-");
line since it is not needed, fixing the issue. Also adds tests for thePackageTarget.from_str
function on thescheme/src/lib.rs
file.P.S.: Sorry for the late PR 😅