Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to launch from directory with space in it #2886

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix failure to launch from directory with space in it #2886

merged 2 commits into from
Aug 23, 2024

Conversation

thomash-acinq
Copy link
Member

Fixes #2885

@thomash-acinq thomash-acinq mentioned this pull request Jul 22, 2024
Closed
@thomash-acinq thomash-acinq requested a review from pm47 July 29, 2024 08:49
@t-bast
Copy link
Member

t-bast commented Jul 29, 2024 •
edited
Loading

Seems like the linked issue mentions that this was tested on macOS, was this tested on linux and windows as well? @pm47 can probably do the windows test.

pm47
pm47 reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing intellij github integration

eclair-node/src/main/resources/eclair-node.sh Outdated Show resolved Hide resolved
pm47
pm47 previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm47 can probably do the windows test.

I confirm that it works on windows

@t-bast t-bast merged commit c440007 into master Aug 23, 2024
1 check passed
@t-bast t-bast deleted the space-directory branch August 23, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./bin/eclair-node.sh doesn't work if installation path has a space in it
3 participants
@thomash-acinq @t-bast @pm47