Add logs to onion message relay #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There weren't any logs when relaying onion messages, which makes it impossible to troubleshoot. While we're working on cross-compatibility, we keep those logs at the `INFO` level, and will change some of them to `DEBUG` once stabilized.
thomash-acinq
previously approved these changes
Jul 12, 2024
Log messages that are outside of a message handler are not decorated with MDC fields. We move all logging calls to message handlers to ensure that they have the MDC fields.
thomash-acinq
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There weren't any logs when relaying onion messages, which makes it impossible to troubleshoot. While we're working on cross-compatibility, we keep those logs at the
INFOlevel, and will change some of them toDEBUGonce stabilized.