Add support for funding_fee_credit
#2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
2 times, most recently
from
1c0a6d4
to
eb38767
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
2 times, most recently
from
0e2d7da
to
d4f8eb7
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
from
d4f8eb7
to
41a935b
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
2 times, most recently
from
e616a84
to
b1e18a8
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
5 times, most recently
from
49f2d8b
to
a34f600
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
2 times, most recently
from
e808bb2
to
16c24f9
Compare
pm47
reviewed
Sep 11, 2024
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
4 times, most recently
from
20e263b
to
a69dc8f
Compare
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
from
a69dc8f
to
928c373
Compare
We add an optional feature that lets on-the-fly funding clients accept payments that are too small to pay the fees for an on-the-fly funding. When that happens, the payment amount is added as "fee credit" without performing an on-chain operation. Once enough fee credit has been obtained, we can initiate an on-chain operation to create a channel or a splice by paying part of the fees from the fee credit. This feature makes more efficient use of on-chain transactions by trusting that the seller will honor our fee credit in the future. The fee credit takes precedence over other ways of paying the fees (from the channel balance or future HTLCs), which guarantees that the fee credit eventually converges to 0.
t-bast
force-pushed
the
on-the-fly-funding-fee-credit
branch
from
928c373
to
22b33fc
Compare
pm47
reviewed
Sep 25, 2024
eclair-core/src/test/scala/fr/acinq/eclair/payment/relay/OnTheFlyFundingSpec.scala
Show resolved
Hide resolved
pm47
approved these changes
Sep 26, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an optional feature that lets on-the-fly funding clients accept payments that are too small to pay the fees for an on-the-fly funding. When that happens, the payment amount is added as "fee credit" without performing an on-chain operation. Once enough fee credit has been obtained, we can initiate an on-chain operation to create a channel or a splice by paying part of the fees from the fee credit.
This feature makes more efficient use of on-chain transactions by trusting that the liquidity seller will honor the fee credit in the future. The fee credit takes precedence over other ways of paying the fees (from the channel balance or future HTLCs), which guarantees that the fee credit eventually converges to 0.
This is specified in lightning/blips#41