Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommended_feerates optional message #2860

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add recommended_feerates optional message #2860

merged 2 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. Add recommended_feerates optional message 

    We send to our peers an optional message that tells them the feerates
we'd like to use for funding channels. This lets them know which values
are acceptable to us, in case we reject their funding requests.

This is using an odd type and will be automatically ignored by existing
nodes who don't support that feature.
    @t-bast
    t-bast committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8f26248 View commit details
    Browse the repository at this point in the history

  2. Type CurrentFeerates based on source (#2915) 

    * type `CurrentFeerates` based on source

Feerates are highly subjective and it makes sense to type them based on
the source, to remove ambiguity. We may typically use a more "standard"
feerate source for commitment feerates, and a more "aggressive" feerate
source for funding/closing feerates.

* rename NodeParams.currentFeerates to currentBitcoinCoreFeerates
    @pm47
    pm47 authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    82d90e0 View commit details
    Browse the repository at this point in the history