Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onPreHeaderContextMenu for Column Picker usage #1030

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jun 19, 2024

  • adding new events onPreHeaderContextMenu and onPreHeaderClick which is mostly to be able to open the Column Picker from either the regular column headers OR the Column Group from the Pre-Header when defined
  • also works with/without frozen column
  • fixed some examples where the preheader weren't recalculated after reordering columns or hiding columns from picker
  • Note: before calling the column picker, we need to make sure that the pre-header target element is in fact a column group, because if it's anything then we shouldn't open the column picker (e.g. draggable grouping dropzone)

brave_iIxA1Xts95
brave_L8SrZubJeT

- adding new events `onPreHeaderContextMenu` and `onPreHeaderClick` which is mostly to be able to open the Column Picker from either the regular column headers OR the Column Group from the Pre-Header when defined
@ghiscoding ghiscoding merged commit ea2c175 into master Jun 19, 2024
2 checks passed
@ghiscoding ghiscoding deleted the feat/preheader-events-col-picker branch June 19, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant