[NFY] Exchangeable executors #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Unfinished, sanity check needed. Still to do:
|
| out | ||
| end.lines.map { |ln| path.join(Pathname.new(ln.strip)).realpath.to_s } | ||
| rescue Executor::ExecuteError => e | ||
| raise ArgumentError, "Invalid Git repository #{where.to_s}: #{e}" | ||
| end | ||
|
|
||
| def initialize(where=nil, opts={}) |
There was a problem hiding this comment.
Nitpicking: I don't like the lack of spaces between = for default method arguments. I think it's customary to put the space - https://github.com/bbatsov/ruby-style-guide
If you have a strong preference (I saw it before in other places), we can keep this style, as I don't like inconsistency more ;)
There was a problem hiding this comment.
Not a preference, just a habit from my Python past. I'll try to retrain my fingers, but it's hard to tell how deep did it etch in my muscle memory ;) Thanks for noticing this!
|
Apart from the tiny style complaint, I like it. |
|
Check out https://github.com/jarib/childprocess for JRuby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the best of available mechanisms to execute files (issue #1)