Adds policy name in node details when available #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is not related to the code changed ( |
|
Hi @xamebax, how should I proceed with this PR ? |
|
Hi @thlacroix, thank you for opening this PR! I'm not actively working on this project any more, but I'll try and have a look in the next few days. I think the CI error is a bundler version bug that requires updating travis.yml; I'll do that. :) |
This was referenced Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For people who use policyfiles instead of roles, it would be convenient to have the policy name associated to the node directly displayed at the top of the node details.
If the node doesn't have a policy attached, the line won't be displayed.