Deactivate Bootstrap 2 modal dialogs #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nboisteault
approved these changes
Oct 4, 2024
nworr
approved these changes
Oct 7, 2024
Co-authored-by: Étienne Trimaille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for LWC >=3.9 and the migration to bootstrap 5
This CSS addition prevents old JS scripts from making the map unusable
(example of deprecated scripts: https://github.com/3liz/lizmap-javascript-scripts/blob/master/library/ui/popup_metadata_info/popup.js )
We hide the
#lizmap-modaldiv and sibling if it has a direct modal-header child div (Bootstrap 2)Bootstrap 5 needs a
div.modal-dialogwhich itself contains adiv.modal-headerand adiv.modal-body. In this case, the modal will not be hidden
Funded by 3Liz