GCP filestore restore procedure to also update terraform config #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that after restore via a web console, terraform will end up trying to recreate the filestore instance because it is trying to force
source_backupto be null when it is after the web console restore referencing the backup it was restored from.The fix in this PR is to update the docs to update the terraform config as well after having made a change in the web console. We could reasonably also do a filestore restore using terraform by setting
source_backupdirectly, but that felt like adding complexity to a very sensitive operation. Due to that, I've instead just patched to setsource_backupretroactively in terraform.