terraform, aws: support specifying bucket specific tags #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent is to allow 2i2c:hub-name to be specified. I saw no option to easily and robustly add the 2i2c:hub-name tag automatically by using other config or variables. The `hub_cloud_permissions` variable included details about hub name, but I don't think we could be certain all buckets would be tied to a hub name through that, so it seemed problematic to try to use that information. With that in mind, I settled for explicitly configuring any tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proposed terraform functionality to resolve #4502 - an addition of a
tagskey under auser_bucketsvariable.The intent is to allow
2i2c:hub-nametags (with values likestaging,prod) to be specified. I saw no option to easily and robustly add the tag automatically by using other config or variables. Thehub_cloud_permissionsvariable included details about hub name, but I don't think we could be certain all buckets would be tied to a hub name through that, so it seemed problematic to try to use that information. With that in mind, I settled for explicitly configuring any tags.Note that tags can be updated without re-creating the bucket etc.
This was verified to work via AWS UI: