fix: cover Git 2.32.0, check for amend! commits
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds coverage for the new `amend!` commit prefixes [added with the
`--fixup={reword,amend}...` variants][git-2-32-announcement].
[git-2-32-announcement]: https://github.com/git/git/blob/8b7c11b8668b4e774f81a9f0b4c30144b818f1d1/Documentation/RelNotes/2.32.0.txt#L44-L48
|
A nicer solution would be to make configurable the list of forbidden string in the git history (I would personnaly enjoy to add "wip!" for example) |
AFAIK these aren't part of the normal autosquash flow in Git, which is what this PR was motivated by. Not saying whether or not your suggestion should be implemented, just noting the context here. As for your request, I suspect another issue would be the most effective way to drive discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds coverage for the new
amend!commit prefixes added with the--fixup={reword,amend}...variants.I'm unclear on whether or not this would be considered a breaking change?
Closes #25.