Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Deprecated DSS PubKey #81

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Implementation of Deprecated DSS PubKey #81

merged 4 commits into from
Oct 17, 2023

Conversation

cchance27
Copy link
Contributor

Not sure if your accepting PR's but I went ahead and implemented the SSH-DSS pubkey algorithm, tried to follow your pattern and naming conventions as best as I could.

Have tested it locally connecting to a local device that only supports DSS, as well as some other algorithms that are deprecated but already supported.

Implemented after running into it with #80

@HsuJv
Copy link
Collaborator

HsuJv commented Oct 16, 2023

LGTM, thanks for the contribution,
But if you could help fix the CI warnings so that I can merge 'em into the main?

BRs.

Note:
ssh-dss should be added for both HostKeyAlgorithms & PubkeyAcceptedAlgorithms in this line

run: ssh-keygen -A && sed -i -E "s|(AuthorizedKeysFile).*|\1 %h/.ssh/authorized_keys|g" /etc/ssh/sshd_config && echo "HostKeyAlgorithms=+ssh-rsa" >> /etc/ssh/sshd_config && echo "PubkeyAcceptedAlgorithms=+ssh-rsa" >> /etc/ssh/sshd_config && echo "KexAlgorithms=+diffie-hellman-group14-sha1,diffie-hellman-group1-sha1" >> /etc/ssh/sshd_config && echo "Ciphers=+aes128-cbc,3des-cbc,aes192-cbc,aes256-cbc" >> /etc/ssh/sshd_config && sed -i -E "s/#?(ChallengeResponseAuthentication|PasswordAuthentication).*/\1 yes/g" /etc/ssh/sshd_config

@cchance27
Copy link
Contributor Author

cleaned up the cargo fmt and clippy warnings, and adjusted the CI params should clear now.

@HsuJv
Copy link
Collaborator

HsuJv commented Oct 17, 2023

Close #80

@HsuJv HsuJv closed this Oct 17, 2023
@HsuJv HsuJv reopened this Oct 17, 2023
@HsuJv HsuJv merged commit 477c37a into 1148118271:main Oct 17, 2023
10 of 12 checks passed
@cchance27 cchance27 deleted the pubkey-dsa branch October 17, 2023 00:57
@HsuJv
Copy link
Collaborator

HsuJv commented Oct 17, 2023

Seems we cannot simply configure the server to use ssh-dss like ssh-rsa, which looks strange.
I'll have another release when I manage to fix the CI issue.

BRs.

@HsuJv
Copy link
Collaborator

HsuJv commented Oct 17, 2023

version 0.4.3 is now released

Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants