Fix: logsByTx array does not match transaction array #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater matches the index of the transaction in the array
attente
approved these changes
Aug 11, 2023
pkieltyka
reviewed
Aug 11, 2023
| for _, log := range logs { | ||
| log := log | ||
| out[log.TxIndex] = append(out[log.TxIndex], &log) |
There was a problem hiding this comment.
btw, I do remember writing this function long ago -- and my original implementation was similar to what you have now, but then changed it to place in the TxnIndex ... I can't remember exactly why, but it might have been that some nodes gave these to us in the wrong order or something..? I can't recall, but there was a reason. We can just look out for stuff in future around here if anything with receipt listener is acting up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.