fix un subscription deadlock (#116)

* fix unsubscription deadlock * minor * minor
0xsequence · Mar 22, 2024 · 3877127 · 3877127
1 parent a65c80f
commit 3877127
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/ethmonitor/ethmonitor.go b/ethmonitor/ethmonitor.go
@@ -986,8 +986,11 @@ func (m *Monitor) NumSubscribers() int {
 
 func (m *Monitor) UnsubscribeAll(err error) {
 	m.mu.Lock()
-	defer m.mu.Unlock()
-	for _, sub := range m.subscribers {
+	var subs []*subscriber
+	subs = append(subs, m.subscribers...)
+	m.mu.Unlock()
+
+	for _, sub := range subs {
 		sub.err = err
 		sub.Unsubscribe()
 	}