Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss: deser in #427 #681

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Oct 1, 2024

#427

@einar-polygon this is the more natural way to do what you're trying to do.

  • using serde(remote = ..)
  • not reserializing
  • no needless async

Can you test that it works for your use case?

@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Oct 1, 2024
@einar-polygon einar-polygon marked this pull request as ready for review October 3, 2024 12:01
@einar-polygon einar-polygon requested review from einar-polygon and removed request for muursh, atanmarko and Nashtare October 3, 2024 12:01
Copy link
Contributor

@einar-polygon einar-polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@einar-polygon einar-polygon merged commit 10b6a22 into einar/prefetch_transaction_jumps/pr Oct 3, 2024
16 checks passed
@einar-polygon einar-polygon deleted the 0xaatif/discuss-jumpdest-deser branch October 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants