Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serialize and deserialize to starky proofs #1630

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

armanthepythonguy
Copy link
Contributor

Added serialize and deserialize to starky proofs. We needed this for our ZKML project where we needed to export the proofs into files and read them back to verify. It might be useful for other projects as well !!!

Nashtare

This comment was marked as resolved.

@muursh
Copy link
Member

muursh commented Oct 2, 2024

@armanthepythonguy can you fix the clippy issue then we'll merge

@armanthepythonguy
Copy link
Contributor Author

@armanthepythonguy can you fix the clippy issue then we'll merge

I tried running cargo clippy and I got this
warning[E0602]: unknown lint: clippy::too_long_first_doc_paragraph
|
= note: requested on the command line with -A clippy::too_long_first_doc_paragraph
= note: #[warn(unknown_lints)] on by default

For more information about this error, try rustc --explain E0602.
warning: plonky2_field (lib) generated 1 warning
Checking plonky2 v0.2.2 (/Users/armanaurobindo/Desktop/plonky2/plonky2)
warning: plonky2 (lib) generated 1 warning (1 duplicate)
Checking starky v0.4.0 (/Users/armanaurobindo/Desktop/plonky2/starky)
warning: starky (lib) generated 1 warning (1 duplicate)
Finished dev profile [unoptimized + debuginfo] target(s) in 6.40s

Also I ran cargo fmt and got no changes. Can you please have a look? @Nashtare @muursh

@Nashtare
Copy link
Collaborator

Nashtare commented Oct 2, 2024

@armanthepythonguy you need latest nightly toolchain for this to be triggered

@Nashtare
Copy link
Collaborator

Nashtare commented Oct 2, 2024

Thank you!

@Nashtare Nashtare merged commit 27a972f into 0xPolygonZero:main Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants