Refactor CTL Handling #1629
Open
Refactor CTL Handling #1629
+26
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
approved these changes
Oct 4, 2024
Comment on lines
+253
to
+254
| auxiliary_polys: &[&Option<Vec<F::Extension>>; N], | ||
| auxiliary_polys_next: &[&Option<Vec<F::Extension>>; N], |
There was a problem hiding this comment.
I think these could share the same lifetimes as below
| @@ -250,7 +250,8 @@ where | |||
|
|
|||
| /// Outputs all the CTL data necessary to prove a multi-STARK system. | |||
| pub fn get_ctl_vars_from_proofs<'a, F, C, const D: usize, const N: usize>( | |||
There was a problem hiding this comment.
nit: the name is slightly misleading now, as we're not passing the multi_proof as arg anymore. What about get_ctl_vars_from_aux_polys?
Comment on lines
-189
to
-213
| /// A combination of STARK proofs for independent statements operating on possibly shared variables, | ||
| /// along with Cross-Table Lookup (CTL) challenges to assert consistency of common variables across tables. | ||
| #[derive(Debug, Clone)] | ||
| pub struct MultiProof< | ||
| F: RichField + Extendable<D>, | ||
| C: GenericConfig<D, F = F>, | ||
| const D: usize, | ||
| const N: usize, | ||
| > { | ||
| /// Proofs for all the different STARK modules. | ||
| pub stark_proofs: [StarkProofWithMetadata<F, C, D>; N], | ||
| /// Cross-table lookup challenges. | ||
| pub ctl_challenges: GrandProductChallengeSet<F>, | ||
| } | ||
|
|
||
| impl<F: RichField + Extendable<D>, C: GenericConfig<D, F = F>, const D: usize, const N: usize> | ||
| MultiProof<F, C, D, N> | ||
| { | ||
| /// Returns the degree (i.e. the trace length) of each STARK proof, | ||
| /// from their common [`StarkConfig`]. | ||
| pub fn recover_degree_bits(&self, config: &StarkConfig) -> [usize; N] { | ||
| core::array::from_fn(|i| self.stark_proofs[i].proof.recover_degree_bits(config)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Are we sure we want to remove this from the API? It's a relatively convenient struct to group the whole system together. I'd rather suggest expanding it by implementing some additional helpers if needed (like extracting the aux_polys needed for the new signature above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
get_ctl_vars_from_proofsfunction to acceptauxiliary_polysandauxiliary_polys_nextas explicit parameters rather than extracting them from the proofs. This change decouples the auxiliary polynomial data from the proof structure.