Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monitor): out of range panics #375

Merged
merged 4 commits into from
Sep 18, 2024
Merged

fix(monitor): out of range panics #375

merged 4 commits into from
Sep 18, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Sep 18, 2024 •
edited
Loading

Description

  • Add checks to ensure the selected block has transactions before attempting to access them.
  • Implement bounds checking for the selected transaction index.
  • Log errors for out-of-range selections and empty transaction lists.

Jira / Linear Tickets

image

https://0xpolygon.slack.com/archives/C07AWFULS49/p1726607070863549?thread_ts=1726607034.825629&cid=C07AWFULS49

Testing

polycli monitor --rpc-url https://rpc.cardona.zkevm-rpc.com
  • tried to scroll and explore the different blocks and txs

@leovct leovct requested a review from a team September 18, 2024 08:51
@leovct leovct merged commit 9ab6f2a into 0xPolygon:main Sep 18, 2024
5 checks passed
@leovct leovct deleted the fix/polycli-monitor-memory-panic branch September 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @praetoriansentry