Fork 12 and Deployment Refactor #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that we have some visibility into stop service, it's a bit more clear that the tx spammer is not functional. All of our tests failed due to this check. ``` printing logs for tx-spammer-001--9a1d7d2bf172420ab8f1a9474aecf2f7 /usr/local/bin/spam.sh: line 14: cast: command not found Deploying an ERC20 token... ```
jhkimqd
approved these changes
Sep 23, 2024
leovct
reviewed
Sep 23, 2024
| @@ -9,13 +9,13 @@ PARAMS_YML_PATH="../../params.yml" | |||
|
|
|||
| # Extracting default parameters from the different files. | |||
| echo "Extracting default parameters from input_parser.star..." | |||
| if ! sed -n '/^DEFAULT_ARGS = {/,/^}/ { s/DEFAULT_ARGS = //; s/}/}/; p; }' "$INPUT_PARSER_PATH" | yq --yaml-output >.input_parser.star; then | |||
| if ! sed -n '/^DEFAULT_ARGS = {/,/^}/ { s/DEFAULT_ARGS = //; s/}/}/; p; }' "$INPUT_PARSER_PATH" | yq -S --yaml-output >.input_parser.star; then | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has a refactor of the logic for deploying l1 / l2 contracts along with some changes to the default images and forks. In particular, we're switching to fork 12 by default now.
Changes:
Future work: