chore: update port names #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to kurtosis-tech/kurtosis
that referenced
this pull request
Jun 6, 2024
## Description <!-- Describe this change, how it works, and the motivation behind it. --> Kubernetes adheres to [RFC-6335](https://www.rfc-archive.org/getrfc.php?rfc=6335#gsc.tab=0), which specifies that port names must be between 1 and 15 characters. However, this constraint is currently not enforced by the Kurtosis engine, leading to deployment failures in Kubernetes environments when port names exceed 15 characters. Here is an example that the Kurtosis validation step failed to catch:  This PR resolves the issue by adding an additional validation step for port names. It also refactors the regex definitions in `service.go` and improves the test design for validating service and port names in `service_test.go`. ## Is this change user facing? YES <!-- If yes, please add the "user facing" label to the PR --> <!-- If yes, don't forget to include docs changes where relevant --> ## References (if applicable) <!-- Add relevant Github Issues, Discord threads, or other helpful information. --> <!-- You can auto-close issues by putting "Fixes #XXXX" here. --> - https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L326-L351 - 0xPolygon/kurtosis-cdk#146 (comment)
jarrodwatts
pushed a commit
to jarrodwatts/kurtosis-cdk
that referenced
this pull request
Jun 27, 2024
* chore: update port names * chore: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚨 Breaking Change! 🚨
Kubernetes adheres to RFC-6335, which specifies a character limit for port names ranging from 1 to 15 characters. However, some of the port names defined in the Kurtosis CDK exceed this 15-character limit. This PR addresses this issue by shortening the port names and updating some of the ports with more appropriate names.
zkevm-bridge-service:bridge-rpc=>rpcbridge-grpc=>grpczkevm-bridge-ui:bridge-ui=>web-uizkevm-bridge-proxy:bridge-interface=>web-uizkevm-prover/zkevm-executor:hash-db-server=>hash-dbexecutor-server=>executorReferences (if applicable)
https://polygon.atlassian.net/browse/DVT-1520