[Audit remediation] Issue B: Race Condition Between FilterSequenceBatches and handleReorgs #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
CDK-336-Audit-remediation-race-condition
branch
2 times, most recently
from
e8eb595
to
cc2b364
Compare
begmaroman
reviewed
Jun 20, 2024
begmaroman
approved these changes
Jun 21, 2024
goran-ethernal
force-pushed
the
CDK-336-Audit-remediation-race-condition
branch
from
ea1741f
to
a209970
Compare
goran-ethernal
force-pushed
the
CDK-336-Audit-remediation-race-condition
branch
from
a209970
to
5b61f6b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue found by audit, where a race condition can happen while handling reorgs in the
batchSyncronizerwhen a new sequence of batches is being synced.Since both routines update the start block from which we sync batches, it may happen that reorg detector will update the start block while the sync routine is downloading batches, which can lead to some inconsistent batches.
PR introduces a
synclock which both routines will use, meaning, we will not handle reorg until we finish syncing batches, or we will not sync batches, until we handle a reorg first.