Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synchronization for banana sequences #118

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add synchronization for banana sequences #118

merged 2 commits into from
Sep 13, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Sep 13, 2024 •
edited
Loading

Add support to syncing senqueceBatchesValidium for Banana

Version 0.0.9 is reporting this error:

2024-09-12T14:41:31.687Z ERROR synchronizer/batches.go:231 failed to handle event: unrecognized method id: 165e8a8d

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
22.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joanestebanr joanestebanr self-assigned this Sep 13, 2024
@joanestebanr joanestebanr marked this pull request as ready for review September 13, 2024 13:38
@joanestebanr joanestebanr requested a review from a team as a code owner September 13, 2024 13:38
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@joanestebanr joanestebanr merged commit bc61672 into main Sep 13, 2024
9 checks passed
@joanestebanr joanestebanr deleted the feature/banana_sync branch September 13, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@joanestebanr joanestebanr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanestebanr @Stefan-Ethernal