-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microtonal / scale settings edit broken #274
Comments
Confirming this report: I can reproduce all these bugs in the latest version of the code. I'll work on fixes. |
I have a fix for the missing cursor in "Name" and "Comment", as well as for 2. (which turned out to be an issue also affecting other parts of the UI). But it depends on mruby-zest/mruby-zest-build#41 or an equivalent being merged. So no PR yet. |
Recent update:
Not closing this issue yet because the issue with edits appearing far behind the cursor is not solved. |
Current plans are to remove the tunings/key mappings fields or at least make them non-editable. |
A short update on this issue. I'm working with @marahmbawwab and @top1million on fixing the TextEdit widget which is used for these settings. I acknowledge the decision of switching to non-editable fields here, but feel there is still value in fixing TextEdit since it's used elsewhere in the UI. The cursor / edit point mismatch is being addressed in mruby-zest/mruby-zest-build#92 We'll also tackle some of those other issues:
|
You may want to check host behavior. I think this functionality was problematic with at least how VST2 passed messages.
The host captures CTRL, so this would not be possible in plugin mode. |
Version 3.0.5
Name: no cursor, all edits are at the end of the text.
Comment: no cursor, characters are added to the end of the text and cannot be deleted.
Tunings: cursor is shown, but edits are applied some distance before it. Editing the last two tones is difficult to impossible.
Key mapping: cursor is often shown, but edits are applied earlier, making editing of any key after the 4th or 5th impossible. If I delete the first few keys, I can then also delete some later ones, making it possible to enter a new mapping after a few iterations. Except that the key doesn't work, and each key needs to be on a separate line.
The text was updated successfully, but these errors were encountered: