Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray: unread messages icon fix for linux #1365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aitchessbee
Copy link
Collaborator

@Aitchessbee Aitchessbee commented Mar 29, 2024

Fixes #1364

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@Aitchessbee
Copy link
Collaborator Author

Aitchessbee commented Mar 30, 2024

So the issue was in the window.devicePixelRatio used in renderCanvas code (that is only being run for linux). window.devicePixelRatio takes the value of the scaling factor set on your linux PC, and if it's anything other than 1, the icon breaks... With the scaling factor set to 1 the icon stays the same size irrespective of the scaling factor, which also matches the other tray icons that I had (cloudinary and slack)...

Old -
image

New -
image

@alya
Copy link
Collaborator

alya commented Apr 1, 2024

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

Also, please add before/after screenshots to the PR description.

@Aitchessbee
Copy link
Collaborator Author

Done! Let me know if there are any other changes...

@mkaminsky
Copy link

I've had this problem for a while, under both X11 and Wayland, using a 4K screen with my display scaled to 200%.

I wanted to confirm that the fix here works for me--thanks @Aitchessbee

image

Would love to see this PR included in the next release. Thanks for all the great work on Zulip!

@alya
Copy link
Collaborator

alya commented Aug 27, 2024

@andersk are you up for reviewing this proposed one-line change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taskbar icon broken with unread messages
4 participants