Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update defaults for apiml v3 #4004

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

pablocarle
Copy link
Contributor

@pablocarle pablocarle commented Sep 20, 2024

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

  • Bugfix

Changes proposed in this PR

  • Set zaas component as enabled by default in defaults.yaml. This component is required for API ML to work.
  • Remove unsupported internal connector settings in v3.

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Pablo Hernán Carle <[email protected]>
Copy link

github-actions bot commented Sep 20, 2024

build 6109 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10954913130

Copy link
Contributor

@pj892031 pj892031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess also those attributes for GW doesn't make sense anymore:

    auth:
      provider: zosmf
      zosmf:
        jwtAutoconfiguration: jwt
        serviceId: ibmzosmf
    authorization:
      endpoint:
        enabled: false
      provider: ""

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5435 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-4004/zowe-3.0.0-pr-4004-6109-20240920072110.pax
Running on machine: zzow07
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10954989567

Copy link

github-actions bot commented Sep 20, 2024

build 6120 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962502399

Copy link

github-actions bot commented Sep 20, 2024

build 6121 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962513413

@MarkAckert
Copy link
Member

I guess also those attributes for GW doesn't make sense anymore:

    auth:
      provider: zosmf
      zosmf:
        jwtAutoconfiguration: jwt
        serviceId: ibmzosmf
    authorization:
      endpoint:
        enabled: false
      provider: ""

These attributes are also in the example-zowe.yaml file. Do you mean the attributes don't make sense in either place, or don't make sense in defaults because they're already in the example-zowe file?

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5444 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-4004/zowe-3.0.0-pr-4004-6121-20240920160827.pax
Running on machine: zzow06
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962628580

Copy link

github-actions bot commented Sep 20, 2024

Test workflow 5445 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.0.0-PR-4004/zowe-3.0.0-pr-4004-6120-20240920161016.pax
Running on machine: zzow06
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/10962671735

@MarkAckert
Copy link
Member

I guess also those attributes for GW doesn't make sense anymore:

    auth:
      provider: zosmf
      zosmf:
        jwtAutoconfiguration: jwt
        serviceId: ibmzosmf
    authorization:
      endpoint:
        enabled: false
      provider: ""

These attributes are also in the example-zowe.yaml file. Do you mean the attributes don't make sense in either place, or don't make sense in defaults because they're already in the example-zowe file?

The changes are fine as-is in example-zowe.yaml

@MarkAckert MarkAckert added the Build: None Used in CI label Sep 25, 2024
@MarkAckert MarkAckert merged commit 4152a80 into v3.x/staging Sep 25, 2024
7 of 8 checks passed
@MarkAckert MarkAckert deleted the reboot/chore/update-defaults-apiml branch September 25, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: None Used in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants