Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon theme for light/dark mode #78

Open
hydroEng opened this issue Jul 8, 2023 · 4 comments
Open

New icon theme for light/dark mode #78

hydroEng opened this issue Jul 8, 2023 · 4 comments

Comments

@hydroEng
Copy link

hydroEng commented Jul 8, 2023

Hello,

Following from discussion in #43, it seems the way forward if we ever want a new icon theme is to provide a single set of icons that work in both light and dark mode. I made a pull request #79 for this.

I believe this is very much needed now since LibreOffice now has a dark mode on windows, so this affects usability. Plus, its nice to have a modern theme.

I forked the colibre light variant provided by LO icon designer rizal (see here) and modified it so that it works ok both under light and dark mode. The only change is the color from rizal's set is the color of the links in the unlink citations icon.

Here is how it looks under light and dark mode for Windows/gnome/KDE. (Github making pics blurry for some reason, open in a new tab)

image

@hydroEng hydroEng mentioned this issue Jul 8, 2023
@hydroEng
Copy link
Author

hydroEng commented Jul 8, 2023

Alternatively: A lighter grey instead of green for the unlink citations icon in keeping with the intent.

image

image

@hydroEng
Copy link
Author

@adomasven is there any interest in this? If so I can work on 32px icons (now required for HiDPI compatibility in LO)

@dstillman
Copy link
Member

Thanks for working on this. We'll hopefully have some design time to dedicate to new icons in the not-too-distant future, but we can consider some improvements for better dark-mode compatibility in the meantime.

There shouldn't be unrelated changes to the icons, though. E.g., this uses a new Z with a chunky middle stroke that we wouldn't accept — the Z should match the red Z in the "Zotero" wordmark as much as possible. (The existing LO icons use a Z that isn't right either on that front — it's too tall — but it's closer. Ideally we would just match the wordmark.) Similarly, the existing Add/Edit Bibliography icon is a shelf of books, which much better conveys a bibliography than an open book (which is the icon we use in Zotero for a book section). And the Document Preferences icon is much less clear than the existing gear icon, which is a pretty universal symbol for settings.

If you're not able to work on these things, we totally understand, but then we'll likely need to wait for some official work on this.

@hydroEng
Copy link
Author

hydroEng commented Jul 11, 2023

Ah ok, I understand. I know my way around some design packages but not really a designer by any means (hence only able to edit prior work). I believe this set was originally designed in line with LO's colibre icon set (which is default on windows, hence zotero would look quite native). But I understand your branding concern, I just hope dark mode + hidpi compatible icons will be designed for LO soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants