Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional SwiftLint rules #701

Open
15 tasks
mvasilak opened this issue Jun 13, 2023 · 1 comment
Open
15 tasks

Additional SwiftLint rules #701

mvasilak opened this issue Jun 13, 2023 · 1 comment

Comments

@mvasilak
Copy link
Contributor

Consider adding the following rules with severity: error.
(Check #692 for related discussion)

  • large_tuple
  • line_length
  • type_name
  • accessibility_trait_for_button
  • convenience_type
  • no_magic_numbers
  • weak_delegate
  • contains_over_filter_count
  • contains_over_filter_is_empty
  • function_default_parameter_at_end
  • indentation_width
  • sorted_imports
  • superfluous_else
  • type_contents_order
  • unowned_variable_capture
@michalrentka
Copy link
Contributor

michalrentka commented Jun 14, 2023 •
edited
Loading

I noticed these warnings in Xcode btw:
The anyobject_protocol rule is now deprecated and will be completely removed in a future release.
The unused_capture_list rule is now deprecated and will be completely removed in a future release due to an equivalent warning issued by the Swift compiler.

So we can probably delete those.

(I already deleted them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvasilak @michalrentka