Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust highlight comment icon #646

Open
dstillman opened this issue Mar 24, 2023 · 1 comment
Open

Adjust highlight comment icon #646

dstillman opened this issue Mar 24, 2023 · 1 comment

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/comment/424317/#Comment_424317

Based on the screenshots we should probably adjust the icon to more closely match the desktop in size and position.

We can also play with opacity.
nataliachodelski added a commit to nataliachodelski/zotero-ios that referenced this issue Apr 26, 2023
@nataliachodelski
changes to address zotero#646 - Adjust highlight comment icon
6fecec2 
- reduced note icon size from 22 to 16
- added 50% opacity to fill color used for comment icons
- added 50% opacity to fill color used for note icon that is added highlight
@nataliachodelski nataliachodelski mentioned this issue Apr 26, 2023
Open
@nataliachodelski
Copy link

nataliachodelski commented Apr 27, 2023 •
edited
Loading

@dstillman - Hi Dan, I'm a new contributer to this project. I investigated this issue and made a PR with some changes that I think might address this issue. Could you check it out and let me know what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstillman @nataliachodelski