Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: disambiguation with additional names #150

Open
zepinglee opened this issue Jul 5, 2022 · 0 comments
Open

Bug report: disambiguation with additional names #150

zepinglee opened this issue Jul 5, 2022 · 0 comments

Comments

@zepinglee
Copy link

The spec of givenname-disambiguation-rule="by-cite" says:

Only ambiguous names in ambiguous cites are affected, and disambiguation stops after the first name that eliminates cite ambiguity.

In the following test case, the cites are already disambiguated after expanding the first names ("John Doe, Roe" and "Jack Doe, Roe") and disambiguation should stop. citeproc-rs produces "John Doe, Richard Roe; Jack Doe, Jane Roe" by expanding additional names.

citeproc-rs 2ab195a output:

Diff < left / right > :
<John Doe, Richard Roe; Jack Doe, Jane Roe
>John Doe, Roe; Jack Doe, Roe
>>===== MODE =====>>
citation
<<===== MODE =====<<


>>===== RESULT =====>>
John Doe, Roe; Jack Doe, Roe
<<===== RESULT =====<<


>>===== CSL =====>>
<style
      xmlns="http://purl.org/net/xbiblio/csl"
      class="note"
      version="1.0">
  <info>
    <id />
    <title />
    <updated>2009-08-10T04:49:00+09:00</updated>
  </info>
  <citation
         disambiguate-add-givenname="true"
         givenname-disambiguation-rule="by-cite">
    <layout delimiter="; ">
      <names variable="author">
        <name form="short"/>
      </names>
    </layout>
  </citation>
  <bibliography>
    <layout delimiter="; ">
      <names variable="author">
        <name form="short"/>
      </names>
    </layout>
  </bibliography>
</style>
<<===== CSL =====<<


>>===== CITATION-ITEMS =====>>
[
    [
        {
            "id": "ITEM-1"
        },
        {
            "id": "ITEM-2"
        }
    ]
]
<<===== CITATION-ITEMS =====<<


>>===== INPUT =====>>
[
    {
        "author": [
            {
                "family": "Doe",
                "given": "John"
            },
            {
                "family": "Roe",
                "given": "Richard"
            }
        ],
        "id": "ITEM-1",
        "type": "book"
    },
    {
        "author": [
            {
                "family": "Doe",
                "given": "Jack"
            },
            {
                "family": "Roe",
                "given": "Jane"
            }
        ],
        "id": "ITEM-2",
        "type": "book"
    }
]
<<===== INPUT =====<<
@zepinglee zepinglee changed the title Bug report: disambiguation with additions names Bug report: disambiguation with additional names Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant