Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Node.t into ArrayNode.t and GroupNode.t. #10

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 4, 2024

This reduces the number of runtime checks to determine the kind of node when calling storage functions.

This reduces the number of runtime checks to determine the
kind of node when calling storage functions.
@zoj613 zoj613 added node related to the node module tests relating to tests refactoring labels Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 99.13793% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.32%. Comparing base (901264a) to head (523bcd4).

Files Patch % Lines
lib/node.ml 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   74.50%   74.32%   -0.18%     
==========================================
  Files          13       13              
  Lines        1000     1001       +1     
==========================================
- Hits          745      744       -1     
- Misses        255      257       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit 4760020 into main Jul 4, 2024
3 of 4 checks passed
@zoj613 zoj613 deleted the split_node branch July 4, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node related to the node module refactoring tests relating to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant