You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like we do have a unit test for this in test_fan.py, but it didn't catch the issue, as we're (1) not testing getting a fan_mode attribute report from the device and/or (2) because when fan_mode is changed from ZHA, we're only checking if the attribute was written correctly. Not if the entity was also updated correctly.
Doing either of those things would have caught the issue.
Further fixes and changes will come with #87 in the future.
We should also make sure the Starkvind test is improved for this scenario there (test speed) or shortly after that PR is merged.
The text was updated successfully, but these errors were encountered:
Regarding the issue fixed here (infinite recursion):
It seems like we do have a unit test for this in
test_fan.py
, but it didn't catch the issue, as we're (1) not testing getting afan_mode
attribute report from the device and/or (2) because whenfan_mode
is changed from ZHA, we're only checking if the attribute was written correctly. Not if the entity was also updated correctly.Doing either of those things would have caught the issue.
Further fixes and changes will come with #87 in the future.
We should also make sure the Starkvind test is improved for this scenario there (test speed) or shortly after that PR is merged.
The text was updated successfully, but these errors were encountered: