Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links (inline tool) in email composer behaves erratically #2176

Open
richardolsson opened this issue Sep 26, 2024 · 0 comments
Open

Links (inline tool) in email composer behaves erratically #2176

richardolsson opened this issue Sep 26, 2024 · 0 comments
Assignees
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.

Comments

@richardolsson
Copy link
Member

Description

Our email composer uses the Editor.js library but we have implemented our own link inline block because we felt the included one had a lot of issues. During development, I remember everything working very well, but around the time of release I started noticing this weird behavior. Creating a link works well, but after selecting an existing link the inline tool doesn't work as expected. It doesn't indicate that a link is selected, and there seems to be no way to edit the URL of a link.

Steps to reproduce

  1. Go to https://app.dev.zetkin.org/organize/1/projects
  2. Go into any project or create a new one
  3. Create a new email
  4. Go to the Compose tab
  5. Write some text, e.g. "This is a paragraph and it will contain a link somewhere in the middle."
  6. Select some text in the middle of that sentence, e.g. "a link"
  7. Click the link button and type a URL
  8. Select all or part of the linked text

Expected Behaviour

The toolbar that appears should highlight the link icon and display the input field where I can edit the URL. At this point, clicking the now different link button should remove the link.

Actual Behaviour

The toolbar appears unchanged, and there is no input field to update the URL, but clicking the link button does remove the link.

Screenshots (if you have any)

Creating a link (works well)

image

Selecting an existing link

I would expect to see the link button highlighted (compare with selecting a piece of bold text) and that the input field where I can add the URL to be visible.

image

@richardolsson richardolsson added 🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue. labels Sep 26, 2024
@richardolsson richardolsson changed the title Link block in email composer behaves erratically Links (inline tool) in email composer behaves erratically Sep 26, 2024
@awarn awarn self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.
Projects
None yet
Development

No branches or pull requests

2 participants