Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧱 ZUI: Icon #2165

Open
3 tasks
Tracked by #2111
ziggabyte opened this issue Sep 25, 2024 · 0 comments
Open
3 tasks
Tracked by #2111

🧱 ZUI: Icon #2165

ziggabyte opened this issue Sep 25, 2024 · 0 comments
Labels
🚪 entry-level Good for newcomers 🧱 ZUI Issues related to improvements in reusable ZUI components.

Comments

@ziggabyte
Copy link
Contributor

ziggabyte commented Sep 25, 2024

Description

When we use icons we need it to be simple and easy to make them confirm to our style.

Screenshots

bild

Figma link

You need to be logged into a Figma account to properly view the Figma content.
https://www.figma.com/design/yIQMDEFSgkUOrSaJpg3k7N/ZUI?node-id=11033-145247&t=WTbaUbn5r6vpwXpe-4

Requirements

  • Can set size (small, medium, large)
  • Can take in an icon
  • The sizes and other styles confirm to the styles as described in Figma

Open questions

Ask the designers if it's a correct interpretation of the Figma design to say that icons should always have the gray color they are show with in Figma.

Possible implementations

My (ziggi's) thought is to look at how the reference to an icon is passed as props to, for example, the ZUIIconButton component.

Develop this using Storybook. We want all the design system components to be documented through their own Storybook stories.

For reference, you can look at the already existing ZUI components created on the undocumented/new-design-system branch (not ZUI components that exist on main, as they are not part of the new design system.)

Git

The main git branch for the work on the new design system is undocumented/new-design-system. Unless otherwise instructed, do your work on a new branch branched off from this branch.

Name your branch issue-number/zui-name, ex: issue-928/zui-button for a branch where work is done that is documented in the issue with number 928, where a button component is being made.

@ziggabyte ziggabyte added 🚪 entry-level Good for newcomers 🧱 ZUI Issues related to improvements in reusable ZUI components. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚪 entry-level Good for newcomers 🧱 ZUI Issues related to improvements in reusable ZUI components.
Projects
None yet
Development

No branches or pull requests

1 participant