Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should_update? passing in native objects and expecting native true false return #113

Open
catmando opened this issue Jan 4, 2016 · 1 comment

Comments

@catmando
Copy link
Collaborator

catmando commented Jan 4, 2016

should_update? passes two native object hashes (for new params, and new state) and only works properly if true or false are returned (i.e. nil does not work as false)

This all work aroundable, but a nuisance... Luckily should_update? is not used that frequently. At least lets update the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants