feat: finalize nodev20 branch #388
Conversation
skosito
requested review from
andresaiello,
brewmaster012,
lumtis,
CharlieMc0,
fadeev and
fbac
as code owners
|
|
||
| interface INotSupportedMethods { | ||
| error CallOnRevertNotSupported(); | ||
| error ZETANotSupported(); |
There was a problem hiding this comment.
is there something in GatewayEVM to revert with this?
There was a problem hiding this comment.
What do you mean?
We should prevent using callOnRevert and ZETA functions on EVM side as well
There was a problem hiding this comment.
could you please clarify which functions should be disabled on evm side in context of zeta?
deposit and call are either erc20 or gas, which both deposit zrc20
should we disable using zeta connectors on evm side?
There was a problem hiding this comment.
should we disable using zeta connectors on evm side?
Yes
There was a problem hiding this comment.
i think these are minimal changes for that 9892e63
no need to add reverts in zeta connector since it wont be called from protocol, but even if called, these transfer methods back to connector will revert
on external deposit method using zeta token it will revert as well
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## node/v20.0.2 #388 +/- ##
===============================================
Coverage ? 83.19%
===============================================
Files ? 7
Lines ? 369
Branches ? 124
===============================================
Hits ? 307
Misses ? 61
Partials ? 1 ☔ View full report in Codecov by Sentry. |
|
|
||
| interface INotSupportedMethods { | ||
| error CallOnRevertNotSupported(); | ||
| error ZETANotSupported(); |
There was a problem hiding this comment.
What do you mean?
We should prevent using callOnRevert and ZETA functions on EVM side as well
backports and fixes listed in issue
relevant backports from these 2 PRs:
fix: add pauser role to tss #386
fix: review fixes #383
backport for onCrossChainCall rename: refactor: rename onCrosschainCall and zContext #349