Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #106, expose SvelteToastOptions #107

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

domuk-k
Copy link

@domuk-k domuk-k commented Sep 13, 2024

Fixes #106

build result to be

// index.d.ts
export { default as SvelteToast } from "./SvelteToast.svelte";
export { toast } from "./stores.js";
export type SvelteToastOptions = import('./stores.js').SvelteToastOptions;

usages to be

import { toast, type SvelteToastOptions } from '@zerodevx/svelte-toast';

function myOwnToast(message: string, option: SvelteToastOptions) {
  toast.push(message, option)
}

@zerodevx zerodevx linked an issue Sep 15, 2024 that may be closed by this pull request
@zerodevx
Copy link
Owner

Looks good to me! Thanks so much for your contribution! 🙏

@zerodevx zerodevx merged commit 475e42e into zerodevx:v1 Sep 15, 2024
zerodevx added a commit that referenced this pull request Sep 15, 2024
@zerodevx
Copy link
Owner

zerodevx commented Sep 15, 2024

Oh I just realised this is targeted to v1 branch?

Edit: could you open a new PR targeting master branch?

zerodevx added a commit that referenced this pull request Sep 21, 2024
zerodevx added a commit that referenced this pull request Sep 21, 2024
@domuk-k
Copy link
Author

domuk-k commented Sep 24, 2024

Thank you for merging the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type definition for SvelteToastOptions
2 participants