Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Problem with inversed OneToOne relationships #655

Open
simondaigre opened this issue Jun 27, 2024 · 4 comments · May be fixed by #659
Open

[2.0] Problem with inversed OneToOne relationships #655

simondaigre opened this issue Jun 27, 2024 · 4 comments · May be fixed by #659

Comments

@simondaigre
Copy link

simondaigre commented Jun 27, 2024 •
edited
Loading

Hello there,

I'm upgrading a project from 1.38 to 2.0. With the Rector rule, the upgrade is really smooth, thanks @nikophil !

I just have a minor issue, in one Factory, in the defaults() method, I'm doing something like this :

protected function defaults(): array
{
    return [
        'customer' => CustomerFactory::new()->withUser(),
    ];
}

And in Customer factory :

public function withUser(): self
{
    return $this->with(static fn (): array => ['user' => UserFactory::new()]);
}

With Foundry 1.38, my Customer was containing an User, since 2.0 User is always null.
Is it something deprecated or a bug ?
@simondaigre simondaigre changed the title [2.0] Can't use Reusable Factory "States" (->with()) in defaults() method [2.0] Can't use Reusable Factory "States" (->with()) in defaults() method Jun 27, 2024
@nikophil
Copy link
Member

Hi @simondaigre

With the Rector rule, the upgrade is really smooth

nice to hear that! 😊

You problem definitively sounds like a bug. I'm trying to reproduce it.

@nikophil
Copy link
Member

nikophil commented Jun 27, 2024 •
edited
Loading

hmm I kinda made the same thing, but everything is hydrated as expected 🤔

// Object1Factory
    protected function defaults(): array|callable
    {
        return [
            'object2' => Object2Factory::new()->withSomeObject(),
        ];
    }

// Object2Factory
    public function withSomeObject(): static
    {
        return $this->with(static fn (): array => ['object3' => Object3Factory::new(['prop1' => 'toto'])]);
    }

any chance you create a public reproducer please?

@simondaigre
Copy link
Author

https://github.com/simondaigre/foundry-repro

@nikophil
Copy link
Member

ok, I confirm that there is a bug: CustomerFactory::new()->withUser()->create(); this creates two "customers"

@nikophil nikophil changed the title [2.0] Can't use Reusable Factory "States" (->with()) in defaults() method [2.0] Problem with inversed OneToOne relationships Jun 28, 2024
@nikophil nikophil linked a pull request Jun 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: can create inversed one to one nikophil/foundry
2 participants
@simondaigre @nikophil