Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_proofs: Extract separate provers from SaplingProvingContext #752

Closed
str4d opened this issue Jan 6, 2023 · 1 comment
Closed

zcash_proofs: Extract separate provers from SaplingProvingContext #752

str4d opened this issue Jan 6, 2023 · 1 comment

Comments

@str4d
Copy link
Contributor

str4d commented Jan 6, 2023

Currently, we have a single SaplingProvingContext which we initialize, use to create each Spend and Output proof (along with extra fields for the Spend description), and then call binding_sig to produce bindingSig. The reason for this workflow was that there is a data dependency on the entire transaction to create it. However, this data dependency is only a blocker on creating bindingSig due to computing bsk; the remaining components can be created independently of the whole transaction.

We should extract the per-proof creation logic from SaplingProvingContext, so they can be run independently.

@daira
Copy link
Contributor

daira commented Oct 30, 2023

This was indeed closed by #1001, because #741 can be completed by #1023.

@daira daira closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants