UI: Toolbox: wrap property metadata after n characters

[dexX7]

• 17) Property metadata should be wrapped

In the best case based on the window size, but this could as well be a feature for the next release. More relevant, in my opinion, is to prevent extreme client sizes as shown above.

In this example maximum character numbers of 255 were used for all metadata fields.

[zathras-crypto]

I notice the title says your wallet is running on testnet, but propId 4 is not your created property (are you running regtest and does the wallet still say testnet if running on regtest?).

Thanks
Z

[dexX7]

It's regtestnet, but in 0.9 it shows "testnet" instead of "regtest".

[zathras-crypto]

In the best case based on the window size, but this could as well be a feature for the next release. More relevant, in my opinion, is to prevent extreme client sizes as shown above.

I've gone for immediate protection against extreme client sizes, but need to evaluate the impact of wrapping (as it would use more vertical space for the label and force everything below it to be laid out further down - what the impact of this is I'm not 100% yet). I figure protection via truncation will do the job for 0.0.9.1 and then wrapping can be revisited.

Thanks
Z

8f310a1

[dexX7]

Here is a testnet transaction with that sizes: 852baf404a70f6d194264c226b923040ca33945e30d5dfa5c28e877a6d83938e (still unconfirmed at the moment)

But sounds good for now. :)

[zathras-crypto]

Awesome thanks - I tested on exploitcoin on mainnet and it does the job for data, I'll check out the other fields with your TX in a sec when it confirms :)

[zathras-crypto]

There was a minor issue (now corrected - a841d54) - W is the widest character in non-fixed-width fonts so I think the values are pretty safe for now.

[zathras-crypto]

Leaving open to consider wrapping in next version.

[dexX7]

Two questions, but I'll give it a shot later myself: could the text be copyable? And could there be a tooltip to show the whole description? I would assume this would be a low hanging fruit.

[dexX7]

Hmm... so this is still larger than the minimal size, as it seems. I mean, it's not really a huge issue, but probably the best of both:

[zathras-crypto]

There is a value maxLabelWidth that we can reduce if we feel it's too much bigger than minimal size - currently set at 70 chars but can be tweaked - this is primarily a stopgap until we look at a better way to do it in 0.0.9.2 (eg wrapping).

[dexX7]

I suggest to either close this and open another one for an improved version, or tag this one for 0.0.9.2 as well.

[zathras-crypto]

This is already tagged as a 0.0.9.2 improvement now mate :)