Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ABC doesn't match spec #2104

Closed
dcherian opened this issue Aug 20, 2024 · 2 comments
Closed

Store ABC doesn't match spec #2104

dcherian opened this issue Aug 20, 2024 · 2 comments
Labels
bug Potential issues with the zarr-python library

Comments

@dcherian
Copy link
Contributor

Zarr version

irrelevant

Numcodecs version

irrelevant

Python Version

irrelevant

Operating System

irrelevant

Installation

irrelevant

Description

https://zarr-specs.readthedocs.io/en/latest/v3/core/v3.0.html#abstract-store-interface lists erase_values and erase_prefix which are not present in https://github.com/zarr-developers/zarr-python/blob/v3/src/zarr/abc/store.py.

Also erase has been renamed to delete. it would be good to update one of the two so that both are consistent.

Steps to reproduce

irrelevant

Additional output

No response

@dcherian dcherian added the bug Potential issues with the zarr-python library label Aug 20, 2024
@jhamman
Copy link
Member

jhamman commented Aug 21, 2024

I opened zarr-developers/zarr-specs#307 to clarify that the ABC and the spec need not match. However, we should add the erase_* methods (or something similar).

@jhamman
Copy link
Member

jhamman commented Aug 22, 2024

I'm going to close this in favor of the work in the spec repo to clarify the abstract store interface. I'll open a new issue with erase/delete/rename store methods.

See #2108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Potential issues with the zarr-python library
Projects
None yet
Development

No branches or pull requests

2 participants