Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the default branch of Zarr-Python #15

Closed
MSanKeys963 opened this issue Mar 2, 2022 · 5 comments
Closed

Changing the default branch of Zarr-Python #15

MSanKeys963 opened this issue Mar 2, 2022 · 5 comments

Comments

@MSanKeys963
Copy link
Member

Considering the PRs opened by @grlee77 to add V3 in Zarr-Python, I and @joshmoore propose that we review and merge the PRs by @grlee78 into main and change the default branch to v2-main or something similar.

This will allow us to:

  • Move towards the development of stable V3
  • All the new PRs by the community and users will be opened into main which would have V3 features added by @grlee77. This would help us find any bugs/issues and fix them.

Thoughts?

Cc: @jakirkham @alimanfoo @rabernat @ryan-williams

@MSanKeys963
Copy link
Member Author

Update: @grlee78's PR has passed all the checks and is ready for reviewing and merging.

@joshmoore
Copy link
Member

change the default branch to v2-main or something similar.

I'd like to clarify that in mind this sentence is "change the current default branch (i.e.master) to v2-something".

Basically, there are three calls for objections (and/or requests for alternatives):

  1. Objections to renaming master to main on zarr-python per Switch master branches to main community#44?
  2. Objections to creating separate "stable" and "dev" branches? (Naming to be worked out)
  3. Objections to making the "dev" branch the default in order to drive the v3 work?

@joshmoore
Copy link
Member

Feedback from today's call:

Thoughts still welcome. 898 at least is unblocked, and a decision on this issue will only need to be made when the time for 2.11.2 comes.

@jakirkham
Copy link
Member

Sorry for missing the call. Was out sick most of the week.

Sounds like the branch versioning issue is less pressing.

In case there is still a need for branch versioning, would suggest we consider an approach where the non-latest major version branch is broken out (v2) and main points to the latest major version.

@MSanKeys963
Copy link
Member Author

Is it safe to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants