Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_virtual_dataset error with TEMPO dmr++ #237

Open
danielfromearth opened this issue Sep 5, 2024 · 5 comments · May be fixed by #265
Open

open_virtual_dataset error with TEMPO dmr++ #237

danielfromearth opened this issue Sep 5, 2024 · 5 comments · May be fixed by #265
Labels
bug Something isn't working DMR++

Comments

@danielfromearth
Copy link

danielfromearth commented Sep 5, 2024

Trying to open a DMR++ file from the Tropospheric Emissions: Monitoring of Pollution (TEMPO) satellite-based air quality instrument results in the following TypeError:

result = open_virtual_dataset("https://data.asdc.earthdata.nasa.gov/asdc-prod-protected/TEMPO/TEMPO_NO2_L2_V03/2024.07.25/TEMPO_NO2_L2_V03_20240725T114404Z_S002G06.nc.dmrpp", indexes={}, filetype="dmrpp", reader_options={"storage_options": fs.storage_options})

temp

@ayushnag
Copy link
Contributor

ayushnag commented Sep 5, 2024

Thanks for raising this issue @danielfromearth! This dataset has variables and attributes in the root group and the current code doesn't have logic to handle that. There is already have group parsing logic, I just need to add a case for the root group and your use case will be patched soon.

@TomNicholas TomNicholas added the bug Something isn't working label Sep 5, 2024
@danielfromearth
Copy link
Author

Hi @ayushnag, I was away from this for the past month on some personal leave.
Has there been any progress on this? And either way, would it help to catch up soon (perhaps via Openscapes) about this?

@ayushnag
Copy link
Contributor

Hey @danielfromearth! Yes this fix uncovered quite a few other issues about groups that I have fixed. I will post a PR very soon

@TomNicholas
Copy link
Member

TomNicholas commented Oct 21, 2024

@ayushnag FYI there's no need to wait until the PR is fully working before opening it - I like to open half-baked PRs and mark them as draft just so that people can see what's being worked on

@ayushnag ayushnag linked a pull request Oct 21, 2024 that will close this issue
6 tasks
@ayushnag
Copy link
Contributor

Good idea, I have opened it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DMR++
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants