-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open_virtual_dataset
error with TEMPO dmr++
#237
Comments
Thanks for raising this issue @danielfromearth! This dataset has variables and attributes in the root group and the current code doesn't have logic to handle that. There is already have group parsing logic, I just need to add a case for the root group and your use case will be patched soon. |
Hi @ayushnag, I was away from this for the past month on some personal leave. |
Hey @danielfromearth! Yes this fix uncovered quite a few other issues about groups that I have fixed. I will post a PR very soon |
@ayushnag FYI there's no need to wait until the PR is fully working before opening it - I like to open half-baked PRs and mark them as draft just so that people can see what's being worked on |
Good idea, I have opened it now! |
Trying to open a DMR++ file from the Tropospheric Emissions: Monitoring of Pollution (TEMPO) satellite-based air quality instrument results in the following
TypeError
:The text was updated successfully, but these errors were encountered: