Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Layout: Code needs cleanup to avoid hard to find bugs #121

Open
2 tasks done
BigRoy opened this issue Sep 25, 2024 · 0 comments
Open
2 tasks done

Extract Layout: Code needs cleanup to avoid hard to find bugs #121

BigRoy opened this issue Sep 25, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@BigRoy
Copy link
Contributor

BigRoy commented Sep 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

In the Extract Layout this part overwrites the asset variable, but also grp_name may be undefined and it's quite clear what part of this was intentional.

Expected Behavior:

  • It should not override the parent variable
  • It should make sure that grp_name variable would never be undefined
  • It should clarify / be easy to parse what it's trying to do.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Code check.

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

n/a

Additional context:

No response

@BigRoy BigRoy added the type: bug Something isn't working label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant