Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial Promised context with no warnings #921

Open
2 tasks done
jakubjezek001 opened this issue Sep 26, 2024 · 0 comments
Open
2 tasks done

Editorial Promised context with no warnings #921

jakubjezek001 opened this issue Sep 26, 2024 · 0 comments
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@jakubjezek001
Copy link
Member

jakubjezek001 commented Sep 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

After introducing the has_promised_context attribute for creating context instances (introduced here), we no longer need to warn users that a required context does not exist during the publishing process in the CollectAnatomyInstanceData plugin.

Users might be confused by the warning icon because it suggests there's something wrong with the publishing context, but everything is actually fine.

How would you imagine the implementation of the feature?

We should have the instance data transient key has_promised_context available. This would allow us to change the logging switch from warning to info type in case of an exception.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

image

The image is taken form testing during ynput/ayon-resolve#15.

@jakubjezek001 jakubjezek001 added the type: enhancement Improvement of existing functionality or minor addition label Sep 26, 2024
@BigRoy BigRoy changed the title Editorial Promissed context with no warnings Editorial Promised context with no warnings Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

1 participant