Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow system theme #3

Open
paramaggarwal opened this issue May 10, 2022 · 5 comments
Open

Follow system theme #3

paramaggarwal opened this issue May 10, 2022 · 5 comments

Comments

@paramaggarwal
Copy link

Is there a way to make this follow the system theme? When macOS is in Dark Mode, then the webpages are dark.

@iosdevben
Copy link

Seems like the most important feature to support.

@Volodymyr-13
Copy link

@yep can you please update us with this?

@tfguinan
Copy link

I had a go here and got it kinda working. Aside from requiring building in Xcode, it reloads the page when coming out of dark mode. My first experience with JS so kinda janky. There's probably a better way to do it using the dark reader component.

Nightshift.Recording.mov

@Volodymyr-13
Copy link

Well, reloading page is really bad idea, since user could type something or filling form.. or play music and reload will kill it. deal breaker.

@tfguinan
Copy link

You're right, it should probably call darkReader.disable() instead, though not sure if that will work with the fallback mode. Will keep playing with it when I get some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants