Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lending page buttons not displaying #245

Open
terencechow opened this issue Feb 7, 2021 · 1 comment
Open

Lending page buttons not displaying #245

terencechow opened this issue Feb 7, 2021 · 1 comment

Comments

@terencechow
Copy link

terencechow commented Feb 7, 2021 •
edited
Loading

https://github.com/iearn-finance/iearn-finance/blob/develop/src/components/lending/supplyAsset.jsx#L401-L403

is resulting in below screenshot.

Screen Shot 2021-02-06 at 8 40 56 PM

Note that my asset balance is 0 but it shows up as "0.0000000000"
Screen Shot 2021-02-06 at 8 49 20 PM
0xSake added a commit to 0xSake/iearn-finance that referenced this issue Feb 23, 2021
@0xSake
fix(lending): ensure supplyAsset button text appears
edb3902 
- a bug was reported that asset.balance is a string so none of these conditionals pass (yearn#245)
- cast asset.balance to a Number so the equality checks works
@0xSake 0xSake mentioned this issue Feb 23, 2021
Merged
@0xSake
Copy link
Contributor

0xSake commented Feb 23, 2021

Thank you for the detailed bug report @terencechow 😁. Fixed this and the withdraw button in #251

ghost pushed a commit that referenced this issue Feb 23, 2021
@0xSake
fix(lending): ensure supplyAsset button text appears
28aa8ac 
- a bug was reported that asset.balance is a string so none of these conditionals pass (#245)
- cast asset.balance to a Number so the equality checks works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terencechow @0xSake