Force calculations getting massively screwed up in Wakanda mod

[SpacedOutChicken]

Is there an existing issue for this?

• I have searched the existing issues

Game Version

4.12.12-patch2

Describe the bug

Something about the Black Panther unit in my Wakanda for Unciv mod is messing up the force calculator. The unit itself has a base strength of 20, but it scales with era (maximum strength bonus is 400% during the Future era). Building this unit causes the force calculator to give the civilization a strength of over 800,000. The unit is not actually that overwhelmingly strong.

Steps to Reproduce

1. Enable Wakanda for Unciv mod
2. Build the Sacred Mound, causing the Black Panther unit to appear
3. Wait one turn for the force calculator to catch up to the changes made
4. The force displayed will now be unreasonably large

Screenshots

Link to save file

https://github.com/SpacedOutChicken/Wakanda-for-Unciv

Operating System

Windows

Additional Information

No response

[SomeTroglodyte]

Seems like an overarching problem, not limited to era conditionals:

Unciv/core/src/com/unciv/models/ruleset/unit/BaseUnit.kt

Lines 488 to 504 in 0f2a697

	UniqueType.Strength -> {
	if (unique.params[0].toInt() <= 0) continue
	if (unique.conditionals.any { it.type == UniqueType.ConditionalVsUnits }) { // Bonus vs some units - a quarter of the bonus
	power *= (unique.params[0].toInt() / 4f).toPercent()
	} else if (
	unique.conditionals.any {
	it.type == UniqueType.ConditionalVsCity // City Attack - half the bonus
	|| it.type == UniqueType.ConditionalAttacking // Attack - half the bonus
	|| it.type == UniqueType.ConditionalDefending // Defense - half the bonus
	|| it.type == UniqueType.ConditionalFightingInTiles
	} // Bonus in terrain or feature - half the bonus
	) {
	power *= (unique.params[0].toInt() / 2f).toPercent()
	} else {
	power *= (unique.params[0].toInt()).toPercent() // Static bonus
	}
	}

... Any conditional not special-cased in that if (bad - should be when) decision tree is ignored and the Strength bonus evaluated as if unconditional, thus multiplying like rabbits.
Simplest would be testing unique.conditionals.isEmpty and only applying full bonus in that case, dropping the else (so zero bonus if no known conditional recognized). Better would be to think of a system to force conditionals that can apply to Strength to define a power calculation weight.

[SomeTroglodyte]

Actually, adding a new metamodifier <Weight for AI force calculation = [amount]> or somesuch, then deprecating the big if might be the best answer...? ... PR done. If it is merged, I'd add <Weight for AI force calculation = [100]%> to the medieval one, which gives the BP ~500 points...